feat(notifications): add Slack edit notifications for Ocotillo CRUD#730
Merged
Conversation
Supports the well edit panel in OcotilloUI (BDMS-879): POST and DELETE on /group/{group_id}/things/{thing_id} with 404/409 handling and audit on create.
EditEvent model, Block Kit payload builder, and best-effort background webhook post when SLACK_EDITS_WEBHOOK_URL is set.
…s for edit notifications.
jeremyzilar
changed the title
jirhiker
approved these changes
Jun 22, 2026
Combine PR #729 audit logging on group thing removal with BDMS-921 Slack edit notifications for project add/remove.
Newer FastAPI puts routers in app.routes without a path attribute, so walk nested routes when checking for the admin mount.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
services/edit_notification_helper.pywithEditEvent, Block Kit payload building, and best-effort background Slack posts whenSLACK_EDITS_WEBHOOK_URLis setmodel_adder/model_patcher/model_deleterPOST/DELETE /group/{group_id}/things/{thing_id}) needed by the well edit panelSLACK_EDITS_WEBHOOK_URLandOCOTILLO_UI_BASE_URL, plus unit and integration testsDeploy notes
slack-edits-webhook-urlbefore staging/production deployOCOTILLO_UI_BASE_URL(workflows default to staging/production Ocotillo URLs)Test plan
uv run pytest tests/test_edit_notification_helper.py tests/test_group.py tests/test_asset.py -q